[SYSTEMML-1600] Add version info in MLContext #502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can an Admin verify this patch? |
deroneriksson
suggested changes
May 15, 2017
| StringBuilder sb = new StringBuilder(); | ||
| sb.append("\nWelcome to Apache SystemML!\n"); | ||
| StringBuilder sb = new StringBuilder(); | ||
| sb.append("\nWelcome to Apache SystemML!\n Version "); |
There was a problem hiding this comment.
Hi @krishnakalyan3. Thank you for working on this!
Would you mind moving " Version " to within the if (info.version() != null) { } block? Otherwise, if someone is developing using MLContext in an IDE (where no SystemML jar file is available), they see output such as the following in the console:
Welcome to Apache SystemML!
Version
rather than just
Welcome to Apache SystemML!
Thanks!
There was a problem hiding this comment.
@deroneriksson Thank you for the review. I have made the necessary changes
deroneriksson
approved these changes
May 16, 2017
j143-zz
pushed a commit
to j143-zz/systemml
that referenced
this pull request
Nov 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Append SystemML version number to MLContext welcome message.
Tested local in my local system.
ping @deroneriksson